Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for outdated JSTOR URLS #201

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Add support for outdated JSTOR URLS #201

merged 1 commit into from
Oct 2, 2017

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #201 into development will decrease coverage by 0.1%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development     #201      +/-   ##
=================================================
- Coverage           62.5%   62.39%   -0.11%     
- Complexity          1195     1196       +1     
=================================================
  Files                  8        8              
  Lines               2320     2324       +4     
=================================================
  Hits                1450     1450              
- Misses               870      874       +4
Impacted Files Coverage Δ Complexity Δ
Template.php 74.84% <33.33%> (-0.2%) 1125 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc0ce1...a091889. Read the comment docs.

@ms609
Copy link
Owner

ms609 commented Oct 2, 2017

Great call! Are you able to add a corresponding test case to the pull request?

@GlazerMann
Copy link
Collaborator Author

Done as a separate pull. That’s the best I can do from my phine

@GlazerMann
Copy link
Collaborator Author

I should note that I did verify that jstor does not rewrite bad urls, so we don’t have to worry about that

@ms609 ms609 merged commit d3f719e into ms609:development Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants