Some bibcode data is bad #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #366 +/- ##
=================================================
+ Coverage 82.62% 83.03% +0.41%
- Complexity 1311 1314 +3
=================================================
Files 7 7
Lines 2365 2370 +5
=================================================
+ Hits 1954 1968 +14
+ Misses 411 402 -9
Continue to review full report at Codecov.
|
ms609
reviewed
Dec 1, 2017
Template.php
Outdated
| @@ -418,6 +418,7 @@ public function add_if_new($param_name, $value) { | |||
| return FALSE; | |||
|
|
|||
| case "periodical": case "journal": | |||
| if (strtolower($this->get('journal')) === 'arxiv e-prints') $this->forget('journal'); // Update to real data | |||
There was a problem hiding this comment.
Should we instead check that the journal title is not any of BAD_TITLES?
There was a problem hiding this comment.
Excellent point. Will do. I will rue the day when a hippie starts the open access data journal “Unknown”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages of "arXiv:1711.02260" is returned along with volume of "1711" and journal of "arxiv e-prints".