Add option to use the Citoid API in Zotero format #3732
Conversation
tests/phpunit/TemplateTest.php
Outdated
| public function testUnPaywall2() : void { | ||
| $text = "{{cite journal|doi=10.1145/358589.358596|doi-access=free}}"; | ||
| $text = "{{cite journal|doi=10.1007/s11075-018-0599-7}}"; |
There was a problem hiding this comment.
doi:10.1007/s11075-018-0599-7 is actually a case which should find an URL from http://arxiv.org/abs/1804.09042 , but I suppose that's added as parameter rather than as URL. I'm not actually sure it's that important to test that doi-access=free citations are left alone.
The only difference is that it takes GET requests rather than POST, and the URL is passed in the URL rather than POST data.
* Actually test Unpaywall in Unpaywall tests. * Remove broken tests or parameters for SemanticScholar. They are no longer relevant now that SemanticScholar has removed most of the content it had. * Also remove an unnecessary check for SemanticScholar output from the Unpaywall API. * Just remove the broken SemanticScholar test
They're valid repository URLs.
2) TemplateTest::testGoogleBooksExpansionNEW Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'cite book' +'cite web'
|
Verbose phpunit says things like |
Also change a biorxiv test which was the only one left failing.
|
I have no idea how |
Codecov Report
@@ Coverage Diff @@
## master #3732 +/- ##
============================================
- Coverage 85.60% 85.19% -0.42%
- Complexity 3765 3833 +68
============================================
Files 12 12
Lines 7176 7274 +98
============================================
+ Hits 6143 6197 +54
- Misses 1033 1077 +44
Continue to review full report at Codecov.
|
The only difference is that it takes GET requests rather than POST,
and the URL is passed in the URL rather than POST data.