Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only forget publisher for journals if it is same #432

Closed
wants to merge 6 commits into from
Closed

only forget publisher for journals if it is same #432

wants to merge 6 commits into from

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Jul 24, 2018

Includes a test
I believe this is ready to merge
I am NOT saying that this is a good idea. It is still being discussed

@josve05a
Copy link
Contributor

josve05a commented Jul 31, 2018

This is a parameter field which adds content and should not be removed (by a bot) without consensus, not the other way around. We should NOT get consensus in order to NOT remove the parameter.

A manually entered field (which add content) should not be removed by a bot. A manually entered field which is redundant or does not add anything new could be removed by a bot. To change this, consensus needs to be gathered, not the other way around.

@GlazerMann
Copy link
Collaborator Author

GlazerMann commented Jul 31, 2018

https://en.wikipedia.org/wiki/Wikipedia:Citing_sources Only suggested for books.

https://en.wikipedia.org/wiki/Help:Citation_Style_1#Work_and_publisher should not be included unless important

This feature is over three years old just from checking GitHub

@josve05a
Copy link
Contributor

@GlazerMann If it is added, a human has decided that it is important.

@GlazerMann
Copy link
Collaborator Author

The bot has been removing it since February 2014 which is when the code went to GitHub. And it was certainly not new at that point

@josve05a
Copy link
Contributor

Lack of complaint does not equal consensus. Has the bot (previously, or ever) gotten community consensus to remove such fields?

@ms609
Copy link
Owner

ms609 commented Aug 1, 2018

From memory, Cite journal used to specify that publisher should not be set for journals; as such, the bot was implementing a consensus decision. I note now that the documentation does not explicitly mention this. I'm not aware of any style guide that would advocate including a journal's publisher, as it is very difficult to think of a situation where this would be useful information. Nevertheless, I would suggest that Template talk:Cite journal would be an appropriate place to reach a consensus on the appropriate behaviour here.

I'm closing the PR for now; feel free to reopen it once consensus has been obtained / reaffirmed.

@ms609 ms609 closed this Aug 1, 2018
@GlazerMann GlazerMann deleted the patch-10 branch August 3, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants