Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add one more journal #448

Merged
merged 4 commits into from
Jul 29, 2018
Merged

add one more journal #448

merged 4 commits into from
Jul 29, 2018

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@ms609
Copy link
Owner

ms609 commented Jul 28, 2018

Should there be a space before the "Historical"?
More generally, is there any merit in implementing the rule "always capitalize the letter after a colon"? This might help to reduce the number of manual exceptions that we must specify.

@GlazerMann
Copy link
Collaborator Author

Fixed. You are right about needing a more general fix. Merge this and we can do general fix soon

@ms609
Copy link
Owner

ms609 commented Jul 28, 2018

Currently failing constantsTest::testConstantsDefined:
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-' Historical Biology: An International Journal of Paleobiology '
+' Historical Biology: An International Journal Of Paleobiology '

@GlazerMann
Copy link
Collaborator Author

It now works.
Another more general pull exists too now

@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@abc3496). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #448   +/-   ##
=========================================
  Coverage          ?   73.59%           
  Complexity        ?     1404           
=========================================
  Files             ?        9           
  Lines             ?     2397           
  Branches          ?        0           
=========================================
  Hits              ?     1764           
  Misses            ?      633           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc3496...5356944. Read the comment docs.

@ms609 ms609 merged commit c2533bc into ms609:master Jul 29, 2018
@GlazerMann GlazerMann deleted the patch-8 branch July 29, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants