Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert page range to pages if end=start #454

Merged
merged 21 commits into from
Aug 1, 2018
Merged

Convert page range to pages if end=start #454

merged 21 commits into from
Aug 1, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Jul 29, 2018

Convert page ranges where the start and end match to a non range

Took forever because of multiple byte characters

@GlazerMann GlazerMann changed the title Convert page range to pages if end=start not done yet Jul 29, 2018
@GlazerMann GlazerMann changed the title not done yet Convert page range to pages if end=start Jul 29, 2018
@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

Merging #454 into master will decrease coverage by 11.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #454       +/-   ##
============================================
- Coverage     83.73%   72.6%   -11.14%     
- Complexity     1405    1424       +19     
============================================
  Files             9       9               
  Lines          2392    2442       +50     
============================================
- Hits           2003    1773      -230     
- Misses          389     669      +280
Impacted Files Coverage Δ Complexity Δ
Template.php 79.6% <100%> (-5.12%) 1272 <0> (+19)
WikipediaBot.php 0% <0%> (-66.81%) 87% <0%> (ø)
Page.php 63.26% <0%> (-19.05%) 51% <0%> (ø)
expandFns.php 96.61% <0%> (-0.74%) 0% <0%> (ø)
gitpull.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
Comment.php 100% <0%> (ø) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5656c0...6a8f879. Read the comment docs.

Martin R. Smith and others added 4 commits July 30, 2018 06:28
@ms609 ms609 merged commit 9c5e464 into ms609:master Aug 1, 2018
@GlazerMann GlazerMann deleted the patch-16 branch August 4, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants