New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ASIN, if we have ISBN #468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlazerMann
changed the title
Skip ASIN, if it an ISBN and we already have ISBN
Do not add ASIN, if we have ISBN
Jul 30, 2018
GlazerMann
changed the title
Do not add ASIN, if we have ISBN
Remove ASIN, if we have ISBN
Jul 30, 2018
And avoid redundant check
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
========================================
Coverage ? 72.6%
Complexity ? 1430
========================================
Files ? 9
Lines ? 2457
Branches ? 0
========================================
Hits ? 1784
Misses ? 673
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other Bots will just come along and remove this anyway
https://en.wikipedia.org/wiki/Wikipedia:Bots/Requests_for_approval/CitationCleanerBot_3
https://en.wikipedia.org/wiki/Help:Citation_Style_1#Identifiers