Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASIN, if we have ISBN #468

Merged
merged 17 commits into from Aug 1, 2018
Merged

Remove ASIN, if we have ISBN #468

merged 17 commits into from Aug 1, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Jul 30, 2018

@GlazerMann GlazerMann changed the title Skip ASIN, if it an ISBN and we already have ISBN Do not add ASIN, if we have ISBN Jul 30, 2018
@GlazerMann GlazerMann changed the title Do not add ASIN, if we have ISBN Remove ASIN, if we have ISBN Jul 30, 2018
Martin R. Smith added 2 commits August 1, 2018 08:05
And avoid redundant check
@ms609 ms609 merged commit e527c28 into ms609:master Aug 1, 2018
@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c6ea460). Click here to learn what that means.
The diff coverage is 64.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #468   +/-   ##
========================================
  Coverage          ?   72.6%           
  Complexity        ?    1430           
========================================
  Files             ?       9           
  Lines             ?    2457           
  Branches          ?       0           
========================================
  Hits              ?    1784           
  Misses            ?     673           
  Partials          ?       0
Impacted Files Coverage Δ Complexity Δ
Template.php 79.55% <64.7%> (ø) 1278 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ea460...b7228a9. Read the comment docs.

@GlazerMann GlazerMann deleted the patch-8 branch August 15, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants