Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forget "work=" if same as other text #507

Merged
merged 16 commits into from Aug 9, 2018
Merged

Forget "work=" if same as other text #507

merged 16 commits into from Aug 9, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Aug 5, 2018

We never set work, but people do.
Also do the template clean-up for more than just cite journal

@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #507 into master will decrease coverage by 2.95%.
The diff coverage is 57.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #507      +/-   ##
============================================
- Coverage     75.68%   72.72%   -2.96%     
- Complexity     1431     1445      +14     
============================================
  Files             9        9              
  Lines          2459     2471      +12     
============================================
- Hits           1861     1797      -64     
- Misses          598      674      +76
Impacted Files Coverage Δ Complexity Δ
Template.php 79.69% <57.89%> (-4.14%) 1293 <0> (+14)
expandFns.php 95.04% <0%> (-0.83%) 0% <0%> (ø)
Page.php 63.44% <0%> (+0.68%) 51% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fe410...60f2869. Read the comment docs.

@ms609
Copy link
Owner

ms609 commented Aug 6, 2018

Can we add a test for this new behaviour, please?

@GlazerMann
Copy link
Collaborator Author

Tests added. They even caught that I had made a mistake (the code did not remove an empty work= in the original code)

@ms609 ms609 merged commit 06a971d into ms609:master Aug 9, 2018
@GlazerMann GlazerMann deleted the patch-10 branch August 15, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants