Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer landing page url to url #512

Merged
merged 4 commits into from Aug 9, 2018
Merged

Prefer landing page url to url #512

merged 4 commits into from Aug 9, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Aug 6, 2018

The other URL seems to not always be reliable. Just plain "url" seems to involve some post-processing on their part (which is not always right):
https://api.oadoi.org/v2/10.1671/0272-4634(2002)022[0058:ADATDF]2.0.CO;2?email=not@telling.com
This also seems to be more likely to point to the description page instead of the final pdf, which is probably better since most people just want that.
Also, it gives a url more often. See the test that is updated.

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #512 into master will decrease coverage by 3.23%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #512      +/-   ##
============================================
- Coverage     75.73%   72.49%   -3.24%     
  Complexity     1433     1433              
============================================
  Files             9        9              
  Lines          2464     2465       +1     
============================================
- Hits           1866     1787      -79     
- Misses          598      678      +80
Impacted Files Coverage Δ Complexity Δ
Template.php 79.4% <100%> (-4.47%) 1281 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fcec1...a798124. Read the comment docs.

@ms609 ms609 merged commit d476388 into ms609:master Aug 9, 2018
@GlazerMann GlazerMann deleted the patch-21 branch August 15, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants