Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wikilinks from journal & titles names #525

Merged
merged 8 commits into from Aug 14, 2018
Merged

Remove Wikilinks from journal & titles names #525

merged 8 commits into from Aug 14, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Aug 9, 2018

The only thing we leave is if the entire name of a journal is a wikilink

@GlazerMann GlazerMann changed the title Remove Wikilinks from journal names Remove Wikilinks from journal & titles names Aug 9, 2018
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #525 into master will decrease coverage by 2.55%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #525      +/-   ##
============================================
- Coverage     75.67%   73.12%   -2.56%     
- Complexity     1444     1457      +13     
============================================
  Files             9        9              
  Lines          2471     2508      +37     
============================================
- Hits           1870     1834      -36     
- Misses          601      674      +73
Impacted Files Coverage Δ Complexity Δ
Template.php 80.07% <81.81%> (-3.7%) 1305 <0> (+13)
expandFns.php 95.16% <0%> (+0.11%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6123bc5...fb3f7d2. Read the comment docs.

Martin R. Smith and others added 2 commits August 10, 2018 09:29
Piped links should be handled.  Will need a more complex preg_replace expression.
@GlazerMann
Copy link
Collaborator Author

@ms609 It works. Your wikilink examples were evil.

@ms609 ms609 merged commit 0e01e35 into ms609:master Aug 14, 2018
@GlazerMann GlazerMann deleted the patch-35 branch August 15, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants