Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PubMed Searching #534

Merged
merged 21 commits into from Aug 11, 2018
Merged

Fix PubMed Searching #534

merged 21 commits into from Aug 11, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Aug 10, 2018

Do not URL encode DOIs. They must have changed API. (This gives us PMID in test)
Also, after we find a PMID, we then look for a PMC. (This then gives us PMC in test case)
Also added quotes around search terms.

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #534 into master will decrease coverage by 2.88%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #534      +/-   ##
============================================
- Coverage     75.73%   72.85%   -2.89%     
- Complexity     1446     1449       +3     
============================================
  Files             9        9              
  Lines          2477     2479       +2     
============================================
- Hits           1876     1806      -70     
- Misses          601      673      +72
Impacted Files Coverage Δ Complexity Δ
Template.php 79.81% <100%> (-3.99%) 1297 <0> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4843bbc...595bae3. Read the comment docs.

@GlazerMann GlazerMann changed the title Try this out Trying to fix this Aug 10, 2018
@GlazerMann GlazerMann changed the title Trying to fix this Pubmed resolves to DOI Aug 10, 2018
@GlazerMann GlazerMann changed the title Pubmed resolves to DOI Pubmed resolves from DOI Aug 10, 2018
@GlazerMann GlazerMann changed the title Pubmed resolves from DOI Add searching pubmed by DOI Aug 10, 2018
@GlazerMann GlazerMann changed the title Add searching pubmed by DOI Fix PubMed Searching Aug 10, 2018
@ms609 ms609 merged commit f56d4ed into ms609:master Aug 11, 2018
@GlazerMann GlazerMann deleted the patch-42 branch August 11, 2018 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants