support more arxiv urls formats #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
============================================
- Coverage 68.61% 67.05% -1.57%
- Complexity 1609 1622 +13
============================================
Files 12 12
Lines 3202 3217 +15
============================================
- Hits 2197 2157 -40
- Misses 1005 1060 +55
Continue to review full report at Codecov.
|
ms609
requested changes
Sep 4, 2018
ms609
reviewed
Sep 5, 2018
Template.php
Outdated
| @@ -832,7 +832,7 @@ protected function get_identifiers_from_url($url_sent = NULL) { | |||
| } | |||
| return $this->add_if_new("citeseerx", urldecode($match[1])); // We cannot parse these at this time | |||
|
|
|||
| } elseif (preg_match("~\barxiv\.org/.*(?:pdf|abs)/(.+)$~", $url, $match)) { | |||
| } elseif (preg_match("~\barxiv\.org/.*(?:pdf|abs|tp/arxiv/papers/\d{4})/(.+?)(?:\.pdf)?$~us", $url, $match)) { | |||
There was a problem hiding this comment.
Do we need unicode support for URLs?
and have you deliberately omitted the f from ftp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such as https://arxiv.org/ftp/arxiv/papers/1312/1312.7288.pdf