Avoid access violation

[GlazerMann]

The current code crashes

[codecov]

Codecov Report

Merging #732 into master will decrease coverage by 0.84%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #732      +/-   ##
============================================
- Coverage      69.3%   68.45%   -0.85%     
- Complexity     1621     1637      +16     
============================================
  Files            12       12              
  Lines          3264     3313      +49     
============================================
+ Hits           2262     2268       +6     
- Misses         1002     1045      +43

Impacted Files	Coverage Δ	Complexity Δ
Template.php	73.79% <50%> (-2.29%)	1457 <10> (+7)
apiFunctions.php	70.21% <50%> (+2.71%)	0 <0> (ø)	⬇️
Comment.php	100% <0%> (ø)	12% <0%> (+8%)	⬆️
expandFns.php	90.71% <0%> (+0.71%)	0% <0%> (ø)	⬇️
Page.php	74.64% <0%> (+1.28%)	71% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee53e0e...147bdc1. Read the comment docs.

[ms609]

Just to check: Does the unset() FORCE a forget of the URL, which might be overriden / cancelled by checks in forget?

[GlazerMann]

It does force it, but it does not unset via= etc. I don’t think forget has any checks. Also the unset code does crash since all the param stuff is private/protected

[ms609]

Ah, the reason that I didn't use forget here is given in the comment on the previous line; is it still desirable to supress the echo? If not, let's remove the comment; if so, let's add a new function quietly_forget.

[GlazerMann]

@ms609 done