Extract oclc parameters from urls

[GlazerMann]

No description provided.

[codecov]

Codecov Report

Merging #741 into master will decrease coverage by 1.68%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##             master     #741      +/-   ##
============================================
- Coverage     69.35%   67.67%   -1.69%     
- Complexity     1621     1624       +3     
============================================
  Files            12       12              
  Lines          3270     3276       +6     
============================================
- Hits           2268     2217      -51     
- Misses         1002     1059      +57

Impacted Files	Coverage Δ	Complexity Δ
Template.php	73.36% <16.66%> (-2.73%)	1453 <0> (+3)
expandFns.php	90.71% <0%> (+0.71%)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6983395...7018ad2. Read the comment docs.

[ms609]

Just trying to work out why codecov is saying that so little of this patch is covered; does the modified test mean that some code that was previously covered is no longer?

[GlazerMann]

I wonder if the basis of the code coverage has shifted over time. We no longer cover some code since we no longer look for square bracket containing DOIs on pubmed.

[ms609]

Now that I've had time to look into this I notice that the test is wrapped in require_secrets, so won't show up in the codecov tests -- this explains the codecov failure. I've tweaked the test to check the template renaming too; if I've done this right and it passes Travis, feel free to merge.