Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization of wikipedia #743

Merged
merged 7 commits into from
Sep 11, 2018
Merged

Internationalization of wikipedia #743

merged 7 commits into from
Sep 11, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 9, 2018

does not make us run elsewhere, but is a step in the right direction.

@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #743 into master will decrease coverage by 1.58%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
- Coverage     69.49%   67.91%   -1.59%     
  Complexity     1626     1626              
============================================
  Files            12       12              
  Lines          3285     3285              
============================================
- Hits           2283     2231      -52     
- Misses         1002     1054      +52
Impacted Files Coverage Δ Complexity Δ
Page.php 73.65% <100%> (ø) 71 <0> (ø) ⬇️
Template.php 73.63% <0%> (-2.56%) 1454% <0%> (ø)
expandFns.php 90.71% <0%> (+0.71%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07112e2...60b8979. Read the comment docs.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but has now caused a conflict; feel free to resolve & merge.

@ms609 ms609 merged commit e6fe4fc into ms609:master Sep 11, 2018
@GlazerMann GlazerMann deleted the patch-24 branch September 11, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants