Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page ranges should use long dashes #747

Merged
merged 7 commits into from
Sep 13, 2018
Merged

New page ranges should use long dashes #747

merged 7 commits into from
Sep 13, 2018

Conversation

GlazerMann
Copy link
Collaborator

Fixes having to run bot twice

@codecov
Copy link

codecov bot commented Sep 9, 2018 •
edited
Loading

Codecov Report

Merging #747 into master will decrease coverage by 0.88%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #747      +/-   ##
============================================
- Coverage     69.35%   68.46%   -0.89%     
- Complexity     1621     1634      +13     
============================================
  Files            12       12              
  Lines          3270     3311      +41     
============================================
- Hits           2268     2267       -1     
- Misses         1002     1044      +42
Impacted Files Coverage Δ Complexity Δ
Template.php 73.85% <100%> (-2.24%) 1454 <0> (+4)
Comment.php 100% <0%> (ø) 12% <0%> (+8%) ⬆️
expandFns.php 90.71% <0%> (+0.71%) 0% <0%> (ø) ⬇️
Page.php 74.64% <0%> (+1.28%) 71% <0%> (+1%) ⬆️
apiFunctions.php 70.02% <0%> (+1.98%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6983395...f1ad23b. Read the comment docs.

@ms609
Copy link
Owner

ms609 commented Sep 10, 2018

This fix does the job, but it feels like it shouldn't be necessary: do you know why this wasn't caught by the final call to tidy()?

ms609
ms609 approved these changes Sep 13, 2018
View reviewed changes
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking! (-:

@GlazerMann GlazerMann merged commit 0affc46 into ms609:master Sep 13, 2018
@GlazerMann GlazerMann deleted the patch-28 branch September 13, 2018 13:20
GlazerMann added a commit that referenced this pull request Sep 14, 2018
@GlazerMann
Merge master into development (#775)
c5299b2 
* To be finished later

* Reduce memory foorprint

Split out error checking
Un-Set $data once done with it

* Update WikipediaBot.php

* better handling of ends of titles.

* Tidy code

* add more journals

* Update capitalization.php

* Update capitalization.php

* Update capitalization.php

* Update capitalization.php

* more alalphet

* add one more

* Not html

* Only remove double angle quotes if some of both

* Update Template.php

* support cite article

* Italian words

* missing returns

* fix volume=23142(234324) i.e. issues in volume

* reduce changes

* tidy volume =vol(issue)

* Update Template.php

* test splitting volumes and issue

* longer dash

* dashes

* add test

* add eJournal test-first letter is not capitalized

* more double arrow types

* Update capitalization.php

* Update DOItools.php

* Update TemplateTest.php

* Update DOItools.php

* Update capitalization.php

* add explicit characters of UTF-8

* Update capitalization.php

* Update TemplateTest.php

* Update capitalization.php

* recognize that arxiv=eprint in add_if_new

* use functions and their features

* Use functions not direct variables

* Update PageTest.php

* Website (like work) is alias for journal

* Work=website=journal=periodical=.....

* Drop website when adding journal

* Do not want class in for journals

* Simpler code

* Arrows

* more consistent output

* Update Template.php

* Doi's with square brackets cannot search PUBMED

* improve arXiv data usage  (#664)

* Do not match numbers after so called years

* do not match numbers after so called years

* add comment

* I think these are the regex we need

* some code.  please look at

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctions.php

* trim

* one more format

* Debug purposes

* Update apiFunctions.php

* remove debug code & add one more regex

* fix regex

* Update arxivjournal_ref code

* add one more regex https://arxiv.org/abs/1109.1689

* add one more regex

* add more arxiv tests (some fail with current code)

* split tests

* test arxiv

* Update TemplateTest.php

* Update TemplateTest.php

* Update TemplateTest.php

* split off as function

* pull out as function

* Update apiFunctions.php

* Update Template.php

* Update apiFunctions.php

* Update apiFunctions.php

* add a bunch of tests

* fix

* Update TemplateTest.php

* more arxiv formats

* Update TemplateTest.php

* missing space in regex

* more code coverage

* unicode support (#722)

* support more arXiv URLS formats

* arXiv test

* another way to format a journal

* add more words

* make sure arxiv years are sane

* Update capitalization.php

* Avoid using protected methods

* Remove <chem> & <math>: can have unmatched {{ & }}

* <chem> and <math> can contain {{ and }}

* Ready for PHP 7

* Update Page.php

* Update Comment.php

* Use variable names that match their purpose

* Update TemplateTest.php

* Update TemplateTest.php

* More doi clean up

* Update TemplateTest.php

* Add support for bar DOIs

* Update PageTest.php

* Update PageTest.php

* Update Page.php

* Update PageTest.php

* Update PageTest.php

* Update Page.php

* Update Page.php

* Update PageTest.php

* remove pointless default parameter from CS1

* Update TemplateTest.php

* Update Template.php

* Citoid

* Update Template.php

* Update Template.php

* Internationalization of wikipedia

* Update process_page.php

* Update Page.php

* Fix crashes on huge pages -- use atomic regex

* test noticing author-last1 and such

* Update TemplateTest.php

* Update error messages to reflect code name changes

* better date updating from arxiv after publication

* Update apiFunctionsTest.php

* Update apiFunctionsTest.php

* Update apiFunctionsTest.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctionsTest.php

* Fix CSS

* Update Page.php

* Update Page.php

* Update Page.php

* Something funky with the doi

* Update TemplateTest.php

* Update Template.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update Template.php

* Update Template.php

* Update apiFunctions.php

* Update Template.php

* Update apiFunctions.php

* Update apiFunctions.php

* fix DOI code

* Update Template.php

* fix doi checking code

* fix doi code

* use sanitize_doi

* Improve sanitize doi - add features

* add support for books

* quietly_forget

* Update apiFunctions.php

* Update Template.php

* Quiet and non-quiet forget

* Update TemplateTest.php

* Update TemplateTest.php

* Update Template.php

* Update Template.php

* Update Template.php

* Update TemplateTest.php

* Update PageTest.php

* Update TemplateTest.php

* Update PageTest.php

* Update expandFns.php

* Update parameters.php

* Update TemplateTest.php

* Update apiFunctions.php

* Update TemplateTest.php

* Update TemplateTest.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update apiFunctions.php

* Update Template.php

* Update Template.php

* Update Template.php

* Do not lose final periods from first names

* Do not lose period from initials

* Fix initials periods

* Periods on initials

* Update Template.php

* Initials

* Initials

* Update TemplateTest.php

* Update Template.php

* Code legibility

* Line width

Keeping line width within reasonable bounds makes it easier to spot errors at the end of a line (e.g. a missing `}`).

* fix periods after initials

* fix periods after initials

* Fix periods after initials

* Fix author dots

* fix mistake

* fix author dots

* Fix author dots in test to match improved code

* Better adding of dots to initials

* Mess with work less

* New page ranges should use long dashes (#747)

* New page ranges should use long dashes

* Update TemplateTest.php

* Update Template.php

* Update Template.php

* Update TemplateTest.php

* simpler code

* Append category to edit summary in category runs (#763)

* Append category to edit summary

* Concision in edit summaries

Often the end of a summary will be truncated if a lot gets changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms609 ms609 ms609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GlazerMann @ms609