Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOIs code especially for square brackets etc. #751

Merged
merged 15 commits into from
Sep 11, 2018
Merged

Fix DOIs code especially for square brackets etc. #751

merged 15 commits into from
Sep 11, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 10, 2018

mark_inactive_doi needs to be public not protected to call from API file

lots of url encoding for evil square bracket DOIs (and ending with -# is pure evil)

Add missing { } after if that lead to wrong code logic

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@543879b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #751   +/-   ##
=========================================
  Coverage          ?   68.22%           
  Complexity        ?     1626           
=========================================
  Files             ?       12           
  Lines             ?     3286           
  Branches          ?        0           
=========================================
  Hits              ?     2242           
  Misses            ?     1044           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 73.84% <100%> (ø) 1454 <4> (?)
apiFunctions.php 70.02% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543879b...8d612c3. Read the comment docs.

@GlazerMann GlazerMann changed the title Something funky with the doi-add test Fix DOIs code especially for square brackets etc. Sep 10, 2018
@ms609 ms609 merged commit c4efee8 into ms609:master Sep 11, 2018
@GlazerMann GlazerMann deleted the patch-32 branch September 11, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants