Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some support for script-title #809

Merged
merged 3 commits into from
Sep 22, 2018
Merged

add some support for script-title #809

merged 3 commits into from
Sep 22, 2018

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #809 into master will increase coverage by 5.31%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #809      +/-   ##
============================================
+ Coverage     68.82%   74.13%   +5.31%     
- Complexity     1625     1867     +242     
============================================
  Files            13       13              
  Lines          3419     3959     +540     
============================================
+ Hits           2353     2935     +582     
+ Misses         1066     1024      -42
Impacted Files Coverage Δ Complexity Δ
Template.php 82.33% <83.33%> (+6.27%) 1685 <0> (+242) ⬆️
apiFunctions.php 72.28% <0%> (+2.82%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2350c77...2773a45. Read the comment docs.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

($script, $script_value) -- (line 567) -- should this read ($value, $script_value)?

Is trimming $value necessary? Is it possible for a value to contain trailing whitespace?

@GlazerMann
Copy link
Collaborator Author

Your big fix applied. I do not trust metadata to not have spaces in the xml/json/etc

@ms609 ms609 merged commit 40e35dd into master Sep 22, 2018
@ms609 ms609 deleted the GlazerMann-patch-13 branch September 22, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants