Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forget publisher=Amazon when droppping book url #823

Merged
merged 7 commits into from
Sep 27, 2018

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #823 into master will increase coverage by 5.56%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #823      +/-   ##
============================================
+ Coverage     70.22%   75.78%   +5.56%     
- Complexity     1632     1906     +274     
============================================
  Files            13       13              
  Lines          3446     4114     +668     
============================================
+ Hits           2420     3118     +698     
+ Misses         1026      996      -30
Impacted Files Coverage Δ Complexity Δ
Template.php 82.98% <50%> (+6.3%) 1722 <0> (+273) ⬆️
Parameter.php 100% <0%> (ø) 11% <0%> (+1%) ⬆️
api_handlers/zotero.php 85.32% <0%> (+11.24%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0faff49...edef0ab. Read the comment docs.

ms609
ms609 previously requested changes Sep 26, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to amend an existing test so that the forgettery is tested?

@ms609
Copy link
Owner

ms609 commented Sep 26, 2018

Should amazon be added to "Bad publishers" in bad_data.php too?

@GlazerMann
Copy link
Collaborator Author

@ms609 test added

@GlazerMann GlazerMann dismissed ms609’s stale review September 26, 2018 17:57

I think this is donme

@GlazerMann GlazerMann merged commit ba5450b into master Sep 27, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-7 branch September 27, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants