Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter choices in tidy #824

Merged
merged 7 commits into from
Sep 27, 2018
Merged

Fix parameter choices in tidy #824

merged 7 commits into from
Sep 27, 2018

Conversation

GlazerMann
Copy link
Collaborator

publication-place: If any one of publication-place, place, or location is defined, the location will show after the title; if publication-place and place or location are defined, then place or location is shown before the title prefixed with "written at" and publication-place is shown after the title.

publication-date: Date of publication when different from the date the work was written. Displays only if year or date are defined and only if different, else publication-date is used and displayed as date.

orig-year: Original publication year; displays after the date or year. For clarity, please supply specifics. For example: |orig-year=First published 1859 or |orig-year=Composed 1904. Alias: origyear

publication-place: If any one of publication-place, place, or location is defined, the location will show after the title; if publication-place and place or location are defined, then place or location is shown before the title prefixed with "written at" and publication-place is shown after the title.

publication-date: Date of publication when different from the date the work was written. Displays only if year or date are defined and only if different, else publication-date is used and displayed as date.

orig-year: Original publication year; displays after the date or year. For clarity, please supply specifics. For example: |orig-year=First published 1859 or |orig-year=Composed 1904. Alias: origyear
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #824 into master will decrease coverage by <.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #824      +/-   ##
============================================
- Coverage     70.04%   70.04%   -0.01%     
- Complexity     1618     1628      +10     
============================================
  Files            13       13              
  Lines          3422     3435      +13     
============================================
+ Hits           2397     2406       +9     
- Misses         1025     1029       +4
Impacted Files Coverage Δ Complexity Δ
Template.php 76.71% <69.23%> (-0.05%) 1446 <0> (+10)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e2e5e...7d68904. Read the comment docs.

ms609
ms609 previously requested changes Sep 26, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good... Ready for some tests, please!

@GlazerMann GlazerMann dismissed ms609’s stale review September 26, 2018 18:18

tests added. Now lets see if they work

@GlazerMann GlazerMann merged commit 1a418a7 into master Sep 27, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-8 branch September 27, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants