Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n.d. is special. Treat such dates special #825

Merged
merged 5 commits into from
Sep 27, 2018
Merged

Conversation

GlazerMann
Copy link
Collaborator

Do not remove period and such

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #825 into master will increase coverage by 3.71%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #825      +/-   ##
============================================
+ Coverage     69.36%   73.07%   +3.71%     
- Complexity     1612     1898     +286     
============================================
  Files            13       13              
  Lines          3391     4055     +664     
============================================
+ Hits           2352     2963     +611     
- Misses         1039     1092      +53
Impacted Files Coverage Δ Complexity Δ
Template.php 79.47% <100%> (+2.27%) 1716 <0> (+286) ⬆️
expandFns.php 91.3% <0%> (+1.02%) 0% <0%> (ø) ⬇️
api_handlers/zotero.php 58.73% <0%> (+58.73%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05022d8...be51560. Read the comment docs.

GlazerMann and others added 2 commits September 26, 2018 12:54
Are these tests also legitimate? Delete them if not!
@GlazerMann GlazerMann merged commit f3e2e5e into master Sep 27, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-1 branch September 27, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants