Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment exclusion #826

Merged
merged 18 commits into from
Sep 27, 2018
Merged

comment exclusion #826

merged 18 commits into from
Sep 27, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 26, 2018

have to include in set() since it is main point of changing
also have to include in add_if_new() since it has side effects
also have to include in add() since it echos its changing to the user

And other places too. 👎

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #826 into master will increase coverage by 6.57%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #826      +/-   ##
============================================
+ Coverage     69.36%   75.93%   +6.57%     
- Complexity     1612     1861     +249     
============================================
  Files            13       13              
  Lines          3391     4276     +885     
============================================
+ Hits           2352     3247     +895     
+ Misses         1039     1029      -10
Impacted Files Coverage Δ Complexity Δ
Parameter.php 100% <100%> (ø) 11 <0> (+1) ⬆️
Template.php 83.32% <83.33%> (+6.12%) 1676 <0> (+246) ⬆️
expandFns.php 91.3% <0%> (+1.02%) 0% <0%> (ø) ⬇️
Page.php 78.59% <0%> (+3.02%) 75% <0%> (+2%) ⬆️
api_handlers/zotero.php 60.6% <0%> (+60.6%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05022d8...1924f8e. Read the comment docs.

Template.php Outdated Show resolved Hide resolved
@ms609 ms609 merged commit 299fdae into master Sep 27, 2018
@ms609 ms609 deleted the GlazerMann-patch-3 branch September 27, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants