Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add Author2 without author1 #947

Merged
merged 13 commits into from Oct 21, 2018
Merged

Do not add Author2 without author1 #947

merged 13 commits into from Oct 21, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Oct 18, 2018

Current code "counted" empty authors. Why pubmed gives us those, I do not know.

Tests added too (without being asked)

@GlazerMann GlazerMann changed the title Handle existing authors Author2 without author1 Oct 18, 2018
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #947 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #947      +/-   ##
===========================================
+ Coverage     78.03%   78.1%   +0.06%     
  Complexity     1603    1603              
===========================================
  Files            10      10              
  Lines          3337    3338       +1     
===========================================
+ Hits           2604    2607       +3     
+ Misses          733     731       -2
Impacted Files Coverage Δ Complexity Δ
apiFunctions.php 68.55% <100%> (+0.07%) 0 <0> (ø) ⬇️
Template.php 77.65% <0%> (+0.09%) 1503% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b16a11...45df662. Read the comment docs.

@GlazerMann GlazerMann changed the title Author2 without author1 Do not add Author2 without author1 Oct 18, 2018
@GlazerMann GlazerMann requested a review from ms609 October 18, 2018 14:16
@ms609 ms609 merged commit f8ebff4 into master Oct 21, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-4 branch October 21, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants