Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify new dois before adding #972

Closed
wants to merge 9 commits into from
Closed

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@GlazerMann GlazerMann changed the title Verify new dois Verify new dois before adding Oct 23, 2018
@GlazerMann GlazerMann requested a review from ms609 October 23, 2018 19:50
@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@290ea02). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #972   +/-   ##
=========================================
  Coverage          ?   78.31%           
  Complexity        ?     1627           
=========================================
  Files             ?       10           
  Lines             ?     3427           
  Branches          ?        0           
=========================================
  Hits              ?     2684           
  Misses            ?      743           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Template.php 77.59% <100%> (ø) 1522 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290ea02...6733f65. Read the comment docs.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow the motivation for this one?

@GlazerMann
Copy link
Collaborator Author

Some dois that we get do not resolved. I am not sure if this is worth doing either. Perhaps we should count on users using comments to block them.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary for a DOI to resolve for it to be correct? I'd argue that converting the bad doi in the deleted example and adding a broken date is a positive change?

@ms609 ms609 closed this Oct 31, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-5 branch October 31, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants