Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biodiversitylibrary is not parsed well - reject volumes with parethesis #973

Merged
merged 4 commits into from Oct 24, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Oct 23, 2018

volume=ser.6:t.4 (1884)

where 1884 is the year

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #973 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #973      +/-   ##
============================================
- Coverage     78.39%   78.34%   -0.06%     
  Complexity     1614     1614              
============================================
  Files            10       10              
  Lines          3388     3389       +1     
============================================
- Hits           2656     2655       -1     
- Misses          732      734       +2
Impacted Files Coverage Δ Complexity Δ
api_handlers/zotero.php 81.13% <100%> (+0.11%) 0 <0> (ø) ⬇️
Template.php 77.67% <0%> (-0.1%) 1510% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7fa81...31eb6e5. Read the comment docs.

@GlazerMann GlazerMann requested a review from ms609 October 23, 2018 19:50
api_handlers/zotero.php Outdated Show resolved Hide resolved
@GlazerMann GlazerMann merged commit d7c8f95 into master Oct 24, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-7 branch October 24, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants