Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace title={title} with real data #981

Merged
merged 4 commits into from Oct 26, 2018
Merged

Conversation

GlazerMann
Copy link
Collaborator

more common than it should be.......

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #981 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #981      +/-   ##
============================================
+ Coverage      78.4%   78.46%   +0.06%     
- Complexity     1614     1615       +1     
============================================
  Files            10       10              
  Lines          3389     3390       +1     
============================================
+ Hits           2657     2660       +3     
+ Misses          732      730       -2
Impacted Files Coverage Δ Complexity Δ
Template.php 77.86% <100%> (+0.1%) 1511 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c607afe...c734740. Read the comment docs.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create a new array in bad_data as more entries are added to this list?

@GlazerMann
Copy link
Collaborator Author

The next one I add I will make an array

@GlazerMann GlazerMann merged commit e4e4760 into master Oct 26, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-10 branch October 26, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants