Fix cleanup of database resources. #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ResultSet postResult is left open. This might lead to a resource leak with some JDBC drivers or to a “maximum open sursors exceeded” exception, in case too many result sets are left unclosed. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
The ResultSet privResult is left open, if an exception occurs while fetching results in lines 351/352. This might lead to a resource leak with some JDBC drivers or to a “maximum open sursors exceeded” exception, in case too many result sets are left unclosed. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
The PreparedStatement addAdminPstmt is left open. This might lead to a resource leak with some JDBC drivers. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
The PreparedStatement addAdminPstmt is left open. This might lead to a resource leak, since the connection is managed outside the method and might be left open for a long time, such that many open statements accumulate. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
The PreparedStatement addAdminPstmt is left open. This might lead to a resource leak, since the connection is managed outside the method and might be left open for a long time, such that many open statements accumulate. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
The PreparedStatements originalPost and replies and the ResultSets postResult and repliesResult are left open. This might lead to a resource leak, since the connection is managed outside the method and might be left open for a long time, such that many open statements/result sets accumulate. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
The ResultSet privResult is left open, if an exception occurs while fetching results in lines 291 or 305. This might lead to a resource leak with some JDBC drivers or to a “maximum open sursors exceeded” exception, in case too many result sets are left unclosed. See https://stackoverflow.com/questions/4507440/must-jdbc-resultsets-and-statements-be-closed-separately-although-the-connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places in your codebase,
PreparedStatementsorResultsSetsare not closed (generally or in case of errors while executing queries). This pull request fixes several such usages, as identified by our automated detector MUDetect. We would very much appreciate your feedback on our patch. Thank you very much!