Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests 2.32.0 Not supported URL scheme http+unix #73

Open
cartertinney opened this issue May 22, 2024 · 3 comments · May be fixed by #72
Open

Requests 2.32.0 Not supported URL scheme http+unix #73

cartertinney opened this issue May 22, 2024 · 3 comments · May be fixed by #72

Comments

@cartertinney
Copy link

cartertinney commented May 22, 2024 •
edited
Loading

Latest security fix for requests has broken requests-unixsocket. It appears they do not plan to fix the breakage, and are suggesting it be the responsibility of consuming libraries.

Will there be a fix coming for this? Or will PRs for fixing it be accepted/released?
@brasse
Copy link

brasse commented May 22, 2024

Would the same fix work here?

docker/docker-py#3257

@cartertinney
Copy link
Author

@brasse Yes, that is my understanding that that would be all that is required.

@crgwbr
Copy link

crgwbr commented May 22, 2024

FYI to all: since this project seems to be abandoned, but its longevity is important to my team, we've forked the project as requests-unixsocket2. It should be a drop in replacement for this package.

We've migrated the fix for this issue there, merged it, and released to PyPI as part of v0.4.0.

@simondeziel simondeziel linked a pull request May 23, 2024 that will close this issue
Open
@kimfaint kimfaint mentioned this issue May 27, 2024
Closed
@fdelu fdelu mentioned this issue May 29, 2024
Closed
tigarmo added a commit to canonical/craft-application that referenced this issue May 31, 2024
@tigarmo
build(deps): pin requests to <2.32.0
4ddfa3b 
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket,
which in turn is used by craft-parts. Pin this as a "dev" dependency since the
issue is in craft-parts, and not here.

Ref: msabramo/requests-unixsocket#73
tigarmo added a commit to canonical/craft-application that referenced this issue May 31, 2024
@tigarmo
build(deps): pin requests to <2.32.0
e3f9442 
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket,
which in turn is used by craft-parts. Pin this as a "dev" dependency since the
issue is in craft-parts, and not here.

Ref: msabramo/requests-unixsocket#73
tigarmo added a commit to canonical/craft-application that referenced this issue May 31, 2024
@tigarmo
build(deps): pin requests to <2.32.0
a39b3cd 
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket,
which in turn is used by craft-parts. Pin this as a "dev" dependency since the
issue is in craft-parts, and not here.

Ref: msabramo/requests-unixsocket#73
@L3n41c L3n41c mentioned this issue Jun 1, 2024
Merged
4 tasks
arcan1s added a commit to arcan1s/ahriman that referenced this issue Jun 12, 2024
@arcan1s
build: use requests-unixsocket2 fork
42361c3 
Since requests-2.32.0, the http+unix url scheme is brokek, check
msabramo/requests-unixsocket#73 for more
details
arcan1s added a commit to arcan1s/ahriman that referenced this issue Jun 12, 2024
@arcan1s
build: use requests-unixsocket2 fork
e2efe21 
Since requests-2.32.0, the http+unix url scheme is brokek, check
msabramo/requests-unixsocket#73 for more
details
@robin-wayve robin-wayve mentioned this issue Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adapters: fix for requests 2.32.2+ simondeziel/requests-unixsocket
3 participants
@brasse @crgwbr @cartertinney