Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close socket on deletion #28

Merged
merged 1 commit into from Feb 19, 2017
Merged

Close socket on deletion #28

merged 1 commit into from Feb 19, 2017

Conversation

RantyDave
Copy link
Contributor

(bash was complaining)

(bash was complaining)
@msabramo
Copy link
Owner

Thanks for the contribution!

What do you mean "bash was complaining"? I just want to see how to reproduce the problem, so I can test for it.

@msabramo
Copy link
Owner

@RantyDave: Maybe this is what you meant?

(requests-unixsocket) vagrant@vagrant:/vagrant$ python3.5 -Wall sample.py
{
    "Mirrors": null,
    "InsecureRegistryCIDRs": [
        "127.0.0.0/8"
    ],
    "IndexConfigs": {
        "docker.io": {
            "Mirrors": null,
            "Official": true,
            "Secure": true,
            "Name": "docker.io"
        }
    }
}
sys:1: ResourceWarning: unclosed <socket.socket fd=3, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, raddr=/var/run/docker.sock>

?

@msabramo
Copy link
Owner

Thanks, @RantyDave! Your fix makes the ResourceWarning warning go away for me on Python 3.5.2, so I'm going to merge this.

Thanks!

@msabramo msabramo merged commit 0235cc8 into msabramo:master Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants