Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test model #18

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix test model #18

merged 1 commit into from
May 5, 2023

Conversation

sambenfredj
Copy link
Collaborator

Remove subset_max_train from percolator model

closes #14

@sambenfredj sambenfredj requested a review from gessulat May 4, 2023 14:11
gessulat
gessulat approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@gessulat gessulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsetting moved from model to to the brew function. That's why its not needed here anymore.

@sambenfredj sambenfredj merged commit 29f5549 into main May 5, 2023
@sambenfredj sambenfredj deleted the fix/fix_model_test branch July 18, 2023 12:40
gessulat pushed a commit that referenced this pull request Feb 27, 2024
@sambenfredj @gessulat
fix test model: remove subset_max_train from percolator model (#18)
f3d50c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gessulat gessulat gessulat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix test models
2 participants
@sambenfredj @gessulat