Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test confidence #22

Merged
merged 2 commits into from
May 11, 2023
Merged

Fix test confidence #22

merged 2 commits into from
May 11, 2023

Conversation

sambenfredj
Copy link
Collaborator

  • fix bugs for grouped confidence
  • fix test_one_group : create file using psm_df_1000 to create OnDiskPsmDataset.
  • remove test_pickle because confidence does not return dataframe results anymore.
  • add test_multi_groups to test that different group results are saved correctly.
    closes Fix confidence tests #21

- fix bugs for grouped confidence
- fix test_one_group : create file using psm_df_1000 to create OnDiskPsmDataset.
- remove test_pickle because confidence does not return dataframe results anymore.
- add test_multi_groups to test that different group results are saved correctly.
@sambenfredj sambenfredj marked this pull request as draft May 10, 2023 14:24
- overwrite default fdr for update_labels function
- return dataframe for psm_df_1000 to use with LinearPsmDataset
@sambenfredj sambenfredj marked this pull request as ready for review May 10, 2023 14:56
@gessulat gessulat mentioned this pull request May 11, 2023
mokapot/confidence.py Show resolved Hide resolved
mokapot/confidence.py Show resolved Hide resolved
@gessulat gessulat merged commit 3e7dda9 into main May 11, 2023
1 of 10 checks passed
@sambenfredj sambenfredj deleted the fix/fix_test_confidence branch July 18, 2023 12:40
gessulat pushed a commit that referenced this pull request Feb 27, 2024
* Fix test confidence:
- fix bugs for grouped confidence
- fix test_one_group : create file using psm_df_1000 to create OnDiskPsmDataset.
- remove test_pickle because confidence does not return dataframe results anymore.
- add test_multi_groups to test that different group results are saved correctly.

* fix bugs:
- overwrite default fdr for update_labels function
- return dataframe for psm_df_1000 to use with LinearPsmDataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix confidence tests
2 participants