-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default arguments in function definitions #17
Open
msakuta
wants to merge
14
commits into
master
Choose a base branch
from
default-arg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bytecode compiler fails to compile fn_default_expr.dragon, but it's intended.
It's actually a test for the whole pipeline, i.e. parse, compile and interpret.
Since it is more like integration test.
In order to match the behavior with the bytecode. We may extend the language to allow accessing outer variables, but for now we only allow constant expression, which makes the implementation of bytecode much simpler.
If a function default argument accesses an outer variable, it should be an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature exists in C++, Python and many other languages (but interestingly not in Rust).
You can define a function like this:
and you can call this function without explicit arguments:
and it should print
3
.You can also partially provide an argument:
which should print
1002
.See the wiki for more details.