Bugfix constants with no comma at EOL #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed problem, script did not include the value of constants with no comma at end of line. Also included a usage comment in the script.
msantos
added a commit
that referenced
this pull request
Feb 10, 2015
When a value defined in the header file does not have an exact match for an Erlang term, exit immediately and write the value to stderr. Remove preceding/trailing whitespace from the name/values. A trailing tab caused an empty value to be used as the constant. Note because of the way shell pipes work (unless set -o pipefail is used), when the output of the script is piped through "sort | uniq", an error will not cause the whole pipeline to exit, i.e., the output of the script preceding the error will be written to libvirt_constants.hrl. Reported by @ksallberg in: #2 Builds on the fix also provided by ksallberg in: #3 Thanks Kristian!
|
Thank you! The problem here was the script was silently failing when it couldn't match the value to convert into a term. I changed the script to fail in this case. The cause of the term failure was a tab at the end of the line (the ensure_comma() function adds a comma to the input if one isn't there). I folded in your tab substitution. Thanks again for catching this and for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem, script did not include the value of
constants with no comma at end of line. Also
included a usage comment in the script.