Odyssey materials #597
Odyssey materials #597
Conversation
Updated entryData.json file for Odyssey Material. Source for data: INARA, ED Wiki, EDD. FormattedName: Not sufficiently verified. Where I did not know, I have used truncated display name in lower case. SettlementType, BuildingType, ContainerType data from ED Wiki.
|
great stuff! I got a few remarks, I can do the changes myself if you prefer |
| "ValueCr": null, | ||
| "BarterCost": null, | ||
| "BarterValue": null, |
There was a problem hiding this comment.
all the null fields can be completely removed
{
"Value": 10,
"Something": null
}is equivalent to
{
"Value": 10
}There was a problem hiding this comment.
In a few cases the null value indicates that we are missing the value, as in we dont know it yet.
I will leave those inn, or should I put in a diffrent placeholder?
There was a problem hiding this comment.
you could put -1 on the ones you think are missing - it will be a reminder of incomplete data in the gui so it's not forgotten
There was a problem hiding this comment.
Ok, the missing data is the ValueCr for some items.
Updated based on discussion.
|
Thank you. This last part with pull requests and stuff was fun. |
Updated entryData.json file with Odyssey Material.
Source for data: INARA, ED Wiki, EDD.
FormattedName: Not sufficiently verified. Where I did not know, I have used truncated display name in lower case.
SettlementType, BuildingType, ContainerType data from ED Wiki.
My first attempt at a pull request. Scary