Move date time formatter to core:base module

msasikanth · Feb 15, 2024 · c8892b2 · c8892b2
1 parent 86d852e
commit c8892b2
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 12 deletions.
diff --git a/core/base/build.gradle.kts b/core/base/build.gradle.kts
@@ -32,6 +32,8 @@ kotlin {
       implementation(libs.kotlininject.runtime)
     }
 
+    commonTest.dependencies { implementation(libs.kotlin.test) }
+
     androidMain.dependencies { implementation(libs.androidx.annotation) }
   }
 }

diff --git a/...work/parser/DateTimeFormatters.android.kt → ...reader/util/DateTimeFormatters.android.kt b/...work/parser/DateTimeFormatters.android.kt → ...reader/util/DateTimeFormatters.android.kt
@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 Sasikanth Miriyampalli
+ * Copyright 2024 Sasikanth Miriyampalli
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package dev.sasikanth.rss.reader.core.network.parser
+package dev.sasikanth.rss.reader.util
 
 import java.time.Instant
 import java.time.LocalDateTime
@@ -49,7 +49,7 @@ private val dateFormatters =
   )
 
 @Throws(DateTimeFormatException::class)
-internal actual fun String?.dateStringToEpochMillis(clock: Clock): Long? {
+actual fun String?.dateStringToEpochMillis(clock: Clock): Long? {
   if (this.isNullOrBlank()) return null
 
   val currentDate =

diff --git a/...core/network/parser/DateTimeFormatters.kt → ...nth/rss/reader/util/DateTimeFormatters.kt b/...core/network/parser/DateTimeFormatters.kt → ...nth/rss/reader/util/DateTimeFormatters.kt
@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 Sasikanth Miriyampalli
+ * Copyright 2024 Sasikanth Miriyampalli
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,10 +14,10 @@
  * limitations under the License.
  */
 
-package dev.sasikanth.rss.reader.core.network.parser
+package dev.sasikanth.rss.reader.util
 
 import kotlinx.datetime.Clock
 
-internal expect fun String?.dateStringToEpochMillis(clock: Clock = Clock.System): Long?
+expect fun String?.dateStringToEpochMillis(clock: Clock = Clock.System): Long?
 
 data class DateTimeFormatException(val exception: Exception) : Exception()
diff --git a/.../network/parser/DateTimeFormattersTest.kt → ...rss/reader/util/DateTimeFormattersTest.kt b/.../network/parser/DateTimeFormattersTest.kt → ...rss/reader/util/DateTimeFormattersTest.kt
@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 Sasikanth Miriyampalli
+ * Copyright 2024 Sasikanth Miriyampalli
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package dev.sasikanth.rss.reader.core.network.parser
+package dev.sasikanth.rss.reader.util
 
 import kotlin.test.Test
 import kotlin.test.assertEquals

diff --git a/...s/reader/core/network/parser/TestClock.kt → ...ev/sasikanth/rss/reader/util/TestClock.kt b/...s/reader/core/network/parser/TestClock.kt → ...ev/sasikanth/rss/reader/util/TestClock.kt
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package dev.sasikanth.rss.reader.core.network.parser
+package dev.sasikanth.rss.reader.util
 
 import kotlinx.datetime.Clock
 import kotlinx.datetime.Instant

diff --git a/.../network/parser/DateTimeFormatters.ios.kt → ...rss/reader/util/DateTimeFormatters.ios.kt b/.../network/parser/DateTimeFormatters.ios.kt → ...rss/reader/util/DateTimeFormatters.ios.kt
@@ -1,5 +1,5 @@
 /*
- * Copyright 2023 Sasikanth Miriyampalli
+ * Copyright 2024 Sasikanth Miriyampalli
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package dev.sasikanth.rss.reader.core.network.parser
+package dev.sasikanth.rss.reader.util
 
 import kotlinx.datetime.Clock
 import kotlinx.datetime.TimeZone
@@ -69,7 +69,7 @@ private val dateFormatters =
   )
 
 @Throws(DateTimeFormatException::class)
-internal actual fun String?.dateStringToEpochMillis(clock: Clock): Long? {
+actual fun String?.dateStringToEpochMillis(clock: Clock): Long? {
   if (this.isNullOrBlank()) return null
 
   try {

diff --git a/...k/src/commonMain/kotlin/dev/sasikanth/rss/reader/core/network/parser/AtomContentParser.kt b/...k/src/commonMain/kotlin/dev/sasikanth/rss/reader/core/network/parser/AtomContentParser.kt
@@ -30,6 +30,7 @@ import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_SUB
 import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_SUMMARY
 import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_TITLE
 import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_UPDATED
+import dev.sasikanth.rss.reader.util.dateStringToEpochMillis
 import io.ktor.http.Url
 import kotlinx.datetime.Clock
 import org.kobjects.ktxml.api.EventType

diff --git a/...rk/src/commonMain/kotlin/dev/sasikanth/rss/reader/core/network/parser/RssContentParser.kt b/...rk/src/commonMain/kotlin/dev/sasikanth/rss/reader/core/network/parser/RssContentParser.kt
@@ -31,6 +31,7 @@ import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_PUB
 import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_RSS_CHANNEL
 import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_RSS_ITEM
 import dev.sasikanth.rss.reader.core.network.parser.FeedParser.Companion.TAG_TITLE
+import dev.sasikanth.rss.reader.util.dateStringToEpochMillis
 import io.ktor.http.Url
 import kotlinx.datetime.Clock
 import org.kobjects.ktxml.api.EventType