Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gmail IMAP extensions support #28

Closed
diegovar opened this issue Sep 26, 2011 · 7 comments
Closed

Add Gmail IMAP extensions support #28

diegovar opened this issue Sep 26, 2011 · 7 comments

Comments

@diegovar
Copy link

Would you consider adding support for the Gmail IMAP extensions shown here?

http://code.google.com/apis/gmail/imap/

If you think you don't have enough time to implement this, could you point me in the right direction to extending node-imap to support this so I can in the future issue a pull request?

Thanks

Diego

@mscdex
Copy link
Owner

mscdex commented Sep 26, 2011

Are there specific Gmail extensions you had in mind?

@diegovar
Copy link
Author

Mainly access to Gmail email IDs (X-GM-MSGID) and Gmail thread IDs (X-GM-THRID).

@mscdex
Copy link
Owner

mscdex commented Sep 29, 2011

I've added support for those and couple other of the extensions for Gmail with d0d078c. Let me know how it works for you.

@diegovar
Copy link
Author

Awesome, thanks a lot! I'll test it and report any bugs I find :)

@joscha
Copy link

joscha commented Jan 8, 2013

Just in case anyone searches for this.
Took me a dig into the source to find the right way to call search so you don't get the Incorrect number of arguments for search option: X-GM-MSGID error:

imap.search([["X-GM-MSGID", msgId]], function(err, results) {

@mscdex not sure why the double array is needed - for me it seems as if X-GM-MSGID should be on a level with SEARCH and therefore only one array needed.

@mscdex
Copy link
Owner

mscdex commented Jan 9, 2013

@joscha The reason is that there are search criteria that do not require parameters (e.g. 'UNSEEN') and you can specify these as just a single string to make things simple. So having just ["X-GM-MSGID", msgId] could be interpreted as two separate criteria or one criteria with one parameter.

@joscha
Copy link

joscha commented Jan 9, 2013

OK, that makes total sense then, thanks for the clarification!

Jivings added a commit to squarecat/node-imap that referenced this issue Nov 6, 2019
feat: meta theme color for mobile header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants