Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for values that may be understood as "numeric", i.e. has no .toLowerCase() #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlaM
Copy link

@BlaM BlaM commented Jul 11, 2014

Did not dig into the code - so I'm not absolutely sure what this function does, but: The script crashed here for me for a key named "4826". Does not crash anymore when I make sure that we have a string.

@mscdex
Copy link
Owner

mscdex commented Jul 11, 2014

Why is there a numeric value as a key? It doesn't seem like that is legit. Can you enable debugging with debug: console.log to show the line the parser is choking on?

@BlaM
Copy link
Author

BlaM commented Jul 11, 2014

As mentioned I did not really dig into the function. All I saw was that it was dying in that line and that it had a numeric value. What is it supposed to do? Where is the data coming from?

It looked like a lot of single words that come from the mail body.

I can add the console.log again, but I doubt that I will immediately find another mail that will trigger the problem.

Will probably take half a week though until I can get back to it.

I was doing a search() and then feeding the result to fetch just like in the example (even with gmail, too) and the error occured on a twitter mail.

@mscdex
Copy link
Owner

mscdex commented Jul 11, 2014

What version of node-imap are you using?

@BlaM
Copy link
Author

BlaM commented Jul 15, 2014

I used the latest version I got from npm: 0.8.12
https://www.npmjs.org/package/imap

Will have a chance to work with the code today. I'll try to reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants