Fixed tests under OpenBSD #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some code to check for OpenBSD tar, which is not quite compatible to the command line options passed by this module. Also made the method is_gnu() more robust, testing the return code and properly handling STDOUT and STDERR when trying "tar --version". Dependencies added are those already available on standard perl (Config and IPC::Open3).
Added a LICENSE file (GNU GPL v3). Removed MYMETA files (see https://rt.cpan.org/Ticket/Display.html?id=108171). Improved Kwalitee by adding information to Makefile.PL Added a README.md for better formatting in Github project page. Small refactorings and code formating with perltidy.
Re-aligned the comments with the code. Fixed other formating issues.
Tidied code in the method read().
mohammad.anwar@yahoo.com proposed some changes that were applied in PR Both were applied, but #2 broke the tests. Need to find out why because it shouldn't. Removed the version from README file (too much work to maintain it there). Bumped the distribution version.
Suggest code tidy
Implemented refactoring due warnings from Perlcritic.
Did some more refactorings based on perlcritic evaluation. Increased distro version.
Fixed all warnings but one. Small refactorings to increase performance was well. Enhanced error messages.
Using File::Spec on t/001Basic.t to concatenate directories and files in a portable way. Replacing double quotes with single quotes wherever it is possible. Rolled back change to list_reset method to write to a file per result of File::Find::find. Doing chomp() in the proper place inside the list_next method. Replaced global variable $TARDIR with a constant an removed the unnecessary -d test.
From reading the directory content, checking different algorithms to remove the '.' and '..' and measuring the performance of each one.
Added support for Microsoft Windows 10 and later. Skipping tests that will not be supported. Checking during execution of Makefile.PL that tar program is available, and aborting with "NA" if not. Updated the documentation related.
Using Win32::GetOSVersion is tricky and probablying not supporting newer version after Windows Server 2012. Relying that anything with major version equal or higher from 6 should be supported by Microsoft and this distribution.
Not handling properly File::Which which() results when running on MS Windows, fixed that. Go back adding Changes entries per release, and using git tags with it.
Those tests will help to validate the best option to improve write() method performance on different platforms and perl versions. The tests were written to pass anyway, unless something goes terrible wrong.
Fixed bug introduced in Makefile.PL due changes of release 0.30 (thanks to David Cantrell <david@cantrell.org.uk>).
Fixed minor typo in the pod.
Typo fixed by Mohammad S Anwar (#10). Refactored performance tests, and now they will run as TODO to test the hypotesis that there is a better algorithm to write() method.
Fix typo: similarily → similarly.
Covered method that didn't have Pod. Refactored all Pod following best practices. Refactored a single method to be "private". Slightly changed new() to enable unit testing for OS specific configurations.
Increased test coverage. Refactored code to make it easier for testing. Disabled performance-small.t for now. Refactored bzip2 tests.
Added _rem_dots method, a improved way to remove '.' and '..' from readdir(), supposed to be faster than previous implementation with sort() and shift(). Added two more tests to increase testing coverage. Fixed a small bug regarding Pod, that now covers 100% of the code.
Increased the release. Added CONTRIBUTING.md to allow MetaCPAN to show it. Small changes to documentation.
This reverts commit 408ff56.
The unit test for OpenBSD will not run properly, restricted the test to run now only with OpenBSD. Fixed bad formatted Pod.
Fixed tests on Microsoft Windows. Created initial tests to validate on OpenBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some code to check for OpenBSD tar, which is not quite compatible to the command line options passed by this module (not considering that
gtaris installed). Those fixes will makeArchive::Tar::Wrapperavailable to OpenBSD (currently is failing on all reports from CPAN Testers).Also made the method
is_gnu()more robust, testing the return code and properly handlingSTDOUTandSTDERRwhen tryingtar --version.Also made some small refactoring, adding
note()on tests were appropriated.Dependencies added are those already available on standard perl (Config and IPC::Open3).