Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with PHP 5.3 #1

Closed
pableu opened this issue Jun 20, 2016 · 3 comments
Closed

Doesn't work with PHP 5.3 #1

pableu opened this issue Jun 20, 2016 · 3 comments

Comments

@pableu
Copy link

pableu commented Jun 20, 2016

The composer.json says this package requires PHP >= 5.3.2, but it can't work at all with PHP 5.3.

In lib/Fhp/Segment/AbstractSegment.php, you use the short array syntax which was only introduced in PHP 5.4.

If this is the only PHP 5.3 compatibility issue, I'd recommend not using the short array syntax. If there are other issues, it's probably easier to just incrase the minimum required version to 5.4.x in composer.json.

@mschindler83
Copy link
Owner

Hi @pableu,
Thanks for pointing that out.
I've replaced the short array syntax with the valid BC one.
Please let me know if it works now.
Thanks!

@pableu
Copy link
Author

pableu commented Jun 20, 2016

Sweet, I was just about to make a pull request. Yeah, it work perfectly now, thanks!

mschindler83 pushed a commit that referenced this issue Jun 20, 2016
@mschindler83
Copy link
Owner

You're welcome :)
Feel free to open Issues if you find some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants