-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with PHP 5.3 #1
Comments
Hi @pableu, |
Sweet, I was just about to make a pull request. Yeah, it work perfectly now, thanks! |
mschindler83
pushed a commit
that referenced
this issue
Jun 20, 2016
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The composer.json says this package requires PHP >= 5.3.2, but it can't work at all with PHP 5.3.
In
lib/Fhp/Segment/AbstractSegment.php
, you use the short array syntax which was only introduced in PHP 5.4.If this is the only PHP 5.3 compatibility issue, I'd recommend not using the short array syntax. If there are other issues, it's probably easier to just incrase the minimum required version to 5.4.x in composer.json.
The text was updated successfully, but these errors were encountered: