Fix kwalitee issues #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta_yml_has_provides: add MetaProvides::Package build_prereq_matches_use: add Prereqs/BuildRequires https://cpants.cpanauthors.org/dist/Text-Template
|
Not sure that Test::Pod should be a build prereq as thats only used if AUTHOR_TESTING=1, but really there's no harm. Given that this issue is going to affect all of my modules which use my @mschout dzil plugin I will likely fix it there, and then simply doing a new release will take care of this. Thanks for figuring this out! |
|
Thanks for your comment! In that case, I'm closing this PR. Have a great day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for maintaining Text-Template. It was our CPAN-PRC assignment for the month, and we will be submitting a couple pull requests.
This one is for kwalitee score, which you can see at https://cpants.cpanauthors.org/dist/Text-Template
While @manwar's PR #1 handles
use_strictanduse_warnings, this commit here should handle experimental issues.meta_yml_has_providescan be resolved by addingMetaProvides::Package, andbuild_prereq_matches_usecan be resolved by addingPrereqs/BuildRequires.Please let me know if you want me to update any part of this PR. Thanks!
#cpan-prc #team-ziprecruiter #happy-holidays \o/