Skip to content

Commit

Permalink
Use builtin dedent functionality instead of global variables
Browse files Browse the repository at this point in the history
  • Loading branch information
mschwager committed Sep 15, 2016
1 parent f201e1f commit 9bc2187
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions tests/test_filesystem.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python

import os
import textwrap
import unittest

import dns.resolver
Expand All @@ -10,12 +11,6 @@
import fierce


CONTENTS = """nameserver1
nameserver2
nameserver3
"""


class TestFilesystem(fake_filesystem_unittest.TestCase):

def setUp(self):
Expand Down Expand Up @@ -74,10 +69,14 @@ def test_update_resolver_nameservers_multiple_nameservers_no_file(self):
def test_update_resolver_nameservers_no_nameserver_use_file(self):
nameserver_filename = os.path.join("directory", "nameservers")
nameservers = []
contents = textwrap.dedent("""nameserver1
nameserver2
nameserver3
""")

self.fs.CreateFile(
nameserver_filename,
contents=CONTENTS
contents=contents
)

resolver = dns.resolver.Resolver()
Expand All @@ -88,16 +87,20 @@ def test_update_resolver_nameservers_no_nameserver_use_file(self):
nameserver_filename
)

expected = CONTENTS.split()
expected = contents.split()
self.assertEqual(expected, result.nameservers)

def test_update_resolver_nameservers_prefer_nameservers_over_file(self):
nameserver_filename = os.path.join("directory", "nameservers")
nameservers = ['192.168.1.1', '192.168.1.2']
contents = textwrap.dedent("""nameserver1
nameserver2
nameserver3
""")

self.fs.CreateFile(
nameserver_filename,
contents=CONTENTS
contents=contents
)

resolver = dns.resolver.Resolver()
Expand Down

0 comments on commit 9bc2187

Please sign in to comment.