Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent out of bounds error when traversing near 0.0.0.0 (fixes #29) #30

Merged
merged 3 commits into from Apr 29, 2019

Conversation

timmc
Copy link
Contributor

@timmc timmc commented Apr 24, 2019

No description provided.

@coveralls
Copy link

coveralls commented Apr 24, 2019

Coverage Status

Coverage increased (+0.3%) to 60.246% when pulling bdc77ae on timmc:bounded-traverser into 4bb90ae on mschwager:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 60.082% when pulling 4316cdb on timmc:bounded-traverser into 4bb90ae on mschwager:master.

@timmc
Copy link
Contributor Author

timmc commented Apr 24, 2019

Incidentally, in the course of looking into this, I realized that default_expander might not be reachable, given that --traverse=5 is set by default.

Copy link
Owner

@mschwager mschwager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

tests/test_fierce.py Outdated Show resolved Hide resolved
fierce/fierce.py Outdated Show resolved Hide resolved
@mschwager
Copy link
Owner

Oh yeah, and if you could add a line to the CHANGELOG that'd be great!

@timmc
Copy link
Contributor Author

timmc commented Apr 24, 2019

Hah, I knew I was missing something! And I'm usually the one on my team to remind other people of that. :-P I should follow my own checklist.

@mschwager
Copy link
Owner

Hmm, it looks like you added more commits to the PR, but I don't see any file changes. Maybe I'm missing something?

@timmc
Copy link
Contributor Author

timmc commented Apr 26, 2019

Nope, no new commits. Hoping to get to it tonight, though.

@mschwager mschwager merged commit 926c555 into mschwager:master Apr 29, 2019
@mschwager
Copy link
Owner

Thanks @timmc!

@timmc timmc deleted the bounded-traverser branch April 29, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants