Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #31

Closed
wants to merge 2 commits into from
Closed

Add Docker support #31

wants to merge 2 commits into from

Conversation

cesarga
Copy link

@cesarga cesarga commented Oct 16, 2019

I've just added a Dockerfile to build the image and updated the README.md with the usage information.

You can try the image I have already uploaded to Docker hub:

docker run --rm cesarga/fierce --domain google.com --subdomains accounts admin ads

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.246% when pulling 9bd705d on cesarga:master into bfe3409 on mschwager:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.246% when pulling 9bd705d on cesarga:master into bfe3409 on mschwager:master.

@mschwager
Copy link
Owner

Hey @cesarga,

Thanks for opening a PR. I'd like to avoid supporting various packaging mechanisms in this repository (e.g. Docker images, .deb, .rpm, etc). This helps keep the delivery mechanism, and all the rabbit holes involved with that, separate from the code logic. However, I'd definitely encourage you to create a repository for a Fierce Docker image 👍

Thanks again!

@mschwager mschwager closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants