Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding msbuild+CMake+VS2019 CI build #7

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

DarkWanderer
Copy link
Contributor

@DarkWanderer DarkWanderer commented Jul 29, 2021

Adds a basic CI workflow which builds the project in both x86 and x64 platforms.
Example run: https://github.com/DarkWanderer/orbiter/runs/3196658204?check_suite_focus=true

Copy link

@hughesjs hughesjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, would be good if we could get some testing integrated into the pipeline

@SaadiSave
Copy link

It's a good start, would be good if we could get some testing integrated into the pipeline

Are x64 builds supposed to fail?

@DarkWanderer
Copy link
Contributor Author

Are x64 builds supposed to fail?

Yes, the codebase is not currently x64-compatible, but given it's the №1 item in TODO - and there are already a few people working on it - I left it in intentionally

@SaadiSave
Copy link

SaadiSave commented Jul 31, 2021

So maybe run the x64 builds only for commits tagged with x64, so that the actions panel isn't full of failed builds? Or possibly separate the x86 and x64 workflows while x64 is being developed?

@DarkWanderer
Copy link
Contributor Author

I'll let @mschweiger decide on that

@SaadiSave
Copy link

I'll let @mschweiger decide on that

Fair. It was just a suggestion.

Copy link
Collaborator

@mschweiger mschweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting up the CI build. I have one question: will this try to build both the x86 and x64 versions? My master branch currently doesn't build x64. Could this be set up so that it only builds x86 when pushing to the master branch, but builds x64 when pushing to a different, x64-dedicated branch?

@SaadiSave
Copy link

SaadiSave commented Aug 1, 2021

Could this be set up so that it only builds x86 when pushing to the master branch, but builds x64 when pushing to a different, x64-dedicated branch?

Yes, it could. The action just has to be set up to trigger upon push to the x64-branch. But the branch has to be created first. If you don't want to set-up an entire branch, you could use commit and PR tags instead.

@mschweiger
Copy link
Collaborator

I've got a promising branch that might compile for both x86 and x64. About to merge into master, so I'll give the CI setup a try. Fingers crossed!

@mschweiger mschweiger merged commit a64046b into orbitersim:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants