Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number type textfield updates model incorrectly #275

Closed
nikoTM opened this issue Dec 2, 2016 · 2 comments
Closed

Number type textfield updates model incorrectly #275

nikoTM opened this issue Dec 2, 2016 · 2 comments
Labels

Comments

@nikoTM
Copy link

nikoTM commented Dec 2, 2016

As can be seen here, when setting a new value on type="number" textfield, type of the model changes from number to string.

@mseemann mseemann added the Bug label Dec 2, 2016
@mseemann
Copy link
Owner

mseemann commented Dec 2, 2016

will be fixed in the next release.

notes how to fix: because the original input is wrapped by a ControlValueAccessor that is not a NumberValueAccessor the value is not converted back to the type required by the type attribute. In set value the passed in value needs to be converted to a number (parseFloat) if the type is number.

@mseemann
Copy link
Owner

mseemann commented Dec 4, 2016

published in 2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants