Fixes for dataset path verification script #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if polygon is degenerate, i.e. all vertices are on a horizontal line. In that case, use ImageDraw.Draw.line instead.
Change type assertion from list of integer types to check for subtype of np.integer
jmsteitz
changed the title
|
Thanks for this PR. I will add a few more unit tests for this early next week. Still uploading a lot of other code from the project so it's taking me a while to look through this, thanks for your patience. It seems like your bug report was hopefully incorporated into the latest version of Pillow (or will be) -- thanks for filing that with Pillow staff. |
|
Closing for now since I merged in the suggested fixes in the following separate PRs: https://github.com/mseg-dataset/mseg-api/pull/12/files#diff-9f5e240921651cf52ca54f1feed0cb5eR982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if polygon is degenerate, i.e. all vertices are on a horizontal line. In that case, use ImageDraw.Draw.line instead.
Generalize type assertions by checking for subtype of np.integer instead of using a list of some integer types.