Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch streaming to websockets #158

Merged
merged 4 commits into from Jan 27, 2020
Merged

Switch streaming to websockets #158

merged 4 commits into from Jan 27, 2020

Conversation

Niek
Copy link
Contributor

@Niek Niek commented Dec 23, 2019

Fixes #157

Based on the work of https://github.com/timdorr/tesla-api/blob/master/lib/tesla_api/stream.rb

This switches the streaming API to Websockets, since the other simple HTTP streaming is deprecated and no longer working.

@mseminatore
Copy link
Owner

@Niek Thank you for this PR! Unfortunately the CI build did not succeed. Can you take a look and see if you can get a clean build? If so I can merge this in.

@Niek
Copy link
Contributor Author

Niek commented Dec 24, 2019

@mseminatore ah, I'm using yarn - that's why. I have added the changed package-lock.json
now.

@andeplane
Copy link

I guess we could for now just remove the test for the streaming as it doesn't seem like the mock server supports websockets at all apiaryio/api-blueprint#257

I too have this problem and would like to see a websockets implementation in this library :D

@mseminatore
Copy link
Owner

@andeplane Yes I will remove the test for old streaming. Working to get this PR merged.

@Niek
Copy link
Contributor Author

Niek commented Jan 21, 2020

@mseminatore let me know if you need any changes in this PR. As far as I have tested it's working fine.

mseminatore added a commit that referenced this pull request Jan 21, 2020
@mseminatore
Copy link
Owner

@Niek ready to merge this PR. But I see that package-lock.json has moved in master since your PR. Sorry for that. Can you update the handlebars version from ^4.0.1 to ^4.1.2? You should be able to see this in the files diff.

@Niek
Copy link
Contributor Author

Niek commented Jan 22, 2020

@mseminatore I merged the master changes in my branch now - should be good to go

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 91.228% when pulling 81e9ac9 on Niek:websockets into 9e9edd2 on mseminatore:master.

@mseminatore mseminatore merged commit de3a345 into mseminatore:master Jan 27, 2020
@bdaneshgar
Copy link

I'm still getting 502 gateway errors with model 3 as in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simpleStreaming example is not working
5 participants