Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swipe UX bugs #65

Closed
2 of 4 tasks
msfjarvis opened this issue Nov 3, 2020 · 2 comments
Closed
2 of 4 tasks

Swipe UX bugs #65

msfjarvis opened this issue Nov 3, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@msfjarvis
Copy link
Owner

msfjarvis commented Nov 3, 2020 •
edited

The swipe actions added in #60 have a couple bugs/shortcomings that inhibit usability.

  • You can only swipe left to right, not right to left which is unintuitive for right-handed users
  • Swiping to save in the 'Hottest' posts list has no visible affordance for the user
  • Swiping an item in the 'Saved' posts list also clears every post below it (???)
  • There is no un-save action in the 'Hottest' posts list
@msfjarvis msfjarvis added bug Something isn't working good first issue Good for newcomers labels Nov 3, 2020
@msfjarvis msfjarvis mentioned this issue Nov 8, 2020
Merged
1 task
@msfjarvis
Copy link
Owner Author

#73 fixes the 1st and 3rd problem

bors bot added a commit that referenced this issue Nov 9, 2020
@bors @msfjarvis
Merge #73
3cb1c4b 
73: Reimplement LobstersItem to not require swipe actions r=msfjarvis a=msfjarvis

Work towards #65

TODO:
- [x] ~~Figure out why only the last tag shows in the UI~~ Fixed by using `Row` to lay it out like earlier


<details>
<summary>Screenshot</summary>

![screenshot-20201109-113553](https://user-images.githubusercontent.com/13348378/98505720-ce2a4600-227f-11eb-8342-863f2122b928.png)


</details>

Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Owner Author

Well the remaining items are not swipe related anymore so going to file a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msfjarvis