New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMQP: FBP discovery messages should be sent on fanout exchange #13
Comments
This is a breaking protocol change. So far, as far as we know, only the projects under the 'MsgFlo' github organization uses this. |
If the discovery thing becomes and exchange, it might also make sense to send the "Hello World I'm Here" message periodically and not only at start-up. This way coordinator can catch participants even if they started before coordinator joined the game |
I also think that when we do this breaking change, we should rename this queue to something |
Otherwise the msgflo runtime (as subprocess) will start during beginning of entire testsuite and interfere with the other tests. This happens especially because on AQMP the discovery messages are 'consumed' by the runtime (ref issue #13), so just having the runtime present has side-effects.
More important now that periodic sending is (starting to be) implemented, #30 |
That way the messages will not crop up in an unused queue when there is no coordinator,
and there can be multiple consumers of the messages instead of just one.
Requires changes in all the participant libraries, the coordinator and to the documentation.
The text was updated successfully, but these errors were encountered: