Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP: FBP discovery messages should be sent on fanout exchange #13

Open
5 tasks
jonnor opened this issue Jun 19, 2015 · 5 comments
Open
5 tasks

AMQP: FBP discovery messages should be sent on fanout exchange #13

jonnor opened this issue Jun 19, 2015 · 5 comments

Comments

@jonnor
Copy link
Member

jonnor commented Jun 19, 2015

That way the messages will not crop up in an unused queue when there is no coordinator,
and there can be multiple consumers of the messages instead of just one.

Requires changes in all the participant libraries, the coordinator and to the documentation.

  • msgflo-nodejs
  • msgflo-python
  • noflo-runtime-msgflo
  • msgflo-cpp
  • msgflo-rust
@jonnor
Copy link
Member Author

jonnor commented Oct 20, 2015

This is a breaking protocol change. So far, as far as we know, only the projects under the 'MsgFlo' github organization uses this.

@bergie
Copy link
Member

bergie commented Oct 20, 2015

If the discovery thing becomes and exchange, it might also make sense to send the "Hello World I'm Here" message periodically and not only at start-up. This way coordinator can catch participants even if they started before coordinator joined the game

@jonnor
Copy link
Member Author

jonnor commented Nov 21, 2015

I also think that when we do this breaking change, we should rename this queue to something msgflo instead of fbp. Because what travels along are not FBP runtime protocol messages, but msgflo discovery messages. There are many concepts which are closely related or reused, so that a whole service of MsgFlo participant can be seen as one FBP runtime - but I think this distinction will help understand the differences.

@jonnor
Copy link
Member Author

jonnor commented Nov 30, 2015

@bergie see #30 for periodic sending of discovery messages

jonnor added a commit that referenced this issue Apr 21, 2016
Otherwise the msgflo runtime (as subprocess) will start
during beginning of entire testsuite and interfere with the other tests.
This happens especially because on AQMP the discovery messages
are 'consumed' by the runtime (ref issue #13), so just
having the runtime present has side-effects.
@jonnor
Copy link
Member Author

jonnor commented Feb 27, 2017

More important now that periodic sending is (starting to be) implemented, #30

jonnor added a commit to msgflo/msgflo-nodejs that referenced this issue Feb 27, 2017
jonnor added a commit to msgflo/msgflo-nodejs that referenced this issue Feb 27, 2017
jonnor added a commit to msgflo/msgflo-nodejs that referenced this issue Feb 27, 2017
jonnor added a commit to msgflo/msgflo-nodejs that referenced this issue Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants