Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#pragma GCC diagnostic’ #536

Closed
jellychen opened this issue Oct 31, 2016 · 6 comments
Closed

#pragma GCC diagnostic’ #536

jellychen opened this issue Oct 31, 2016 · 6 comments

Comments

@jellychen
Copy link

Build msgpack with CMake。 but so many warning like this “vector_unsigned_char.hpp:50:32: warning: unknown option after ‘#pragma GCC diagnostic’ kind [-Wpragmas]”。 How can I disable these warning??

@redboltz
Copy link
Contributor

@jellychen , thank you for reporting the issue.

Could you tell me your compiler name and version?

@roopaligalgali
Copy link

I am facing the same problem, below is the compiler version -
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3

@redboltz
Copy link
Contributor

@roopaligalgali , thank you for reporting :)

It seems that suppressing maybe-uninitialized functionality is introduced since 4.7. (I tested 4.7.3 and 4.7.4).

I will update the following version checking code and other the same checking:
https://github.com/msgpack/msgpack-c/blob/master/include/msgpack/v1/adaptor/vector_unsigned_char.hpp#L48

@redboltz
Copy link
Contributor

@roopaligalgali , I sent the PR to fix the issue. Could you test it?

Here is an instruction:

git checkout -b redboltz-fix_536 master
git pull https://github.com/redboltz/msgpack-c.git fix_536

@roopaligalgali
Copy link

It works! Bingo!
Thank you.

redboltz added a commit that referenced this issue Mar 15, 2017
@redboltz
Copy link
Contributor

The PR has been merged.
Thanks you for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants